Help
cancel
Showing results for 
Search instead for 
Did you mean: 
Copilot Lvl 3
Message 11 of 47

Re: Feature Request: Switch from ready to draft in pull requests

Or after discussion of the PR, we decide we want to delay the work. Then wanting to turn into a draft PR to avoid merging it by accident instead of just closing the PR.

 

Example of this: https://github.com/jenkinsci/configuration-as-code-plugin/pull/790

Copilot Lvl 2
Message 12 of 47

Re: Feature Request: Switch from ready to draft in pull requests

Agreed. This happens to us frequently, which is why we're still using https://github.com/wip/app instead of Github's Draft PR feature; it does exactly what we need and does it well in that anyone with permission to edit the PR title can easily move a PR in and out of WIP status.

Copilot Lvl 2
Message 13 of 47

Re: Feature Request: Switch from ready to draft in pull requests

Totally support this. It seems like an obvious feature.

Pilot Lvl 1
Message 14 of 47

Re: Feature Request: Switch from ready to draft in pull requests

I wonder if all said and done I'd like this capability, seems like a good idea overall but I can envisage lots of PRs accumulting and switching back and forth from draft to ready and ready to draft possibly causing confusion for others.

 

I consider draft (and I may be the one who originally asked GitHub for this, I suggested something like it over a year ago) to mean "Under no circumstances permit this merge to take place", so my view of this a way of rigidly preventing accidental merging by anyone be they the originator of the PR or a repo owner etc.

 

Calling it "draft" is fine but ultimately it's a safety feature because once merged to a base repo your'e stuck unless you revert the merge which is a drag and can also sometimes confuse people.

 

Another good use of draft is to be able to create a PR that has conflicts so that other can see them and ponder them yet have no desire to ever merge the PR just yet even if conflicts are fixed.

 

 

Ground Controller Lvl 2
Message 15 of 47

Re: Feature Request: Switch from ready to draft in pull requests


@Korporal wrote:

 

Another good use of draft is to be able to create a PR that has conflicts so that other can see them and ponder them yet have no desire to ever merge the PR just yet even if conflicts are fixed.


 

My enterprise instance just got this feature and it does't behave that way. I had a merge conflict on a draft that wasn't reported. The block that normally shows the merge conflicts was replaced with a ready for review button.

Copilot Lvl 2
Message 16 of 47

Re: Feature Request: Switch from ready to draft in pull requests

Any update for GH on this? 

thanks!

Ground Controller Lvl 1
Message 17 of 47

Re: Feature Request: Switch from ready to draft in pull requests

I agree with the idea, that could be very useful.

Ground Controller Lvl 1
Message 18 of 47

Re: Feature Request: Switch from ready to draft in pull requests

+1 : I often forget to mark a pull request as a draft while creating it, and it would super convenient to have a possibility to change the status back to "draft".

Ground Controller Lvl 1
Message 19 of 47

Re: Feature Request: Switch from ready to draft in pull requests

+1 I just changed my mind, and can't take it back...

Ground Controller Lvl 1
Message 20 of 47

Re: Feature Request: Switch from ready to draft in pull requests

This feature is really important and needed to our team, too!!