Help
cancel
Showing results for 
Search instead for 
Did you mean: 
Highlighted
ide
Copilot Lvl 2
Message 1 of 2

Feature Request: Allow only maintainers the ability to approve PRs

Solved! Go to Solution.

On occasion I've seen PRs marked as "approved" by people who aren't the maintainers of the repo at hand and find it noisy at best and possibly misleading. The maintainers of the repo are almost always the ones who are best equipped to review a PR and bear the responsibility of supporting it down the road and approval from a non-maintainer doesn't indicate whether the maintainer will merge the PR. Approvals from maintainers are much more salient.

 

I suspect "approvals" from non-maintainers often come from people who want the PR to be merged for their own reasons, either because they want the same feature or bug fixed and are possibly co-workers of the PR authors and are signaling the PR works fine for them and they want it ASAP. There are other mechanisms for being helpful (ex: providing a test plan) or signaling interest (ex: 👍 reactions) that are more helpful and communicate intent better.

 

This feature might not need to be an option or checkbox and could be the default across the board. Approvals from non-collaborators aren't net positive in my experience and restricting them to collaborators only would keep it clearer whether a PR is actually likely to be merged or not.

 

 

1 Reply
Solution
Community Manager
Message 2 of 2

Re: Feature Request: Allow only maintainers the ability to approve PRs

Hi @ide,

 

Thanks for this feedback! I've logged your feature request in our internal feature request list. Though I can't guarantee anything or share a timeline for this, I can tell you that it's been shared with the appropriate teams for consideration.

 

Please let me know if you have any other questions.

Cheers!

Mark helpful posts with Accept as Solution to help other users locate important info. Don't forget to give Kudos for great content!