Help
cancel
Showing results for 
Search instead for 
Did you mean: 
Ground Controller Lvl 2
Message 31 of 35

Re: Do not require owner approval if the pull request is from an owner?

I wonder if there is a voting for desired features/fixes/changes on github. Because changing that kind of default behaviour would receive my vote. Codeowner should be able to merge pull requests without review or, better option PR from codeowner should receive codeowner's review vote automatically.

 

Let's say we have three codeowners and we want all codeowners to approve changes. So we set that there should be three reviews from codeowners. Then if codeowner creates PR changes only repository admin can merge such PR, becuase it is not possible to get three reviews from codeowners.

Copilot Lvl 2
Message 32 of 35

Re: Do not require owner approval if the pull request is from an owner?

I should add that it's super easy to set up code reviewers in Microsoft TFS. You can set up a minimum number of reviewers, specific single reviewers, multiple reviewers, required review from users in a group, etc. for directories or specific files. Here's their documentation. Would love to see this or similar funcationality in GitHub!

Mission Specialist Lvl 1
Message 33 of 35

Re: Do not require owner approval if the pull request is from an owner?

It won't resolve the issue.

 

We want to give the ability to merge the pull requests without review or with self review for specified users. But github doesn't allow it. The disabling of the mandatory pull requests is also not suitable for us. We want all changes to go through pull request and without direct pushes for everyone.

Ground Controller Lvl 1
Message 34 of 35

Re: Do not require owner approval if the pull request is from an owner?

Is there a chance that what @chpock underlined would be the subject of some upcoming changes?

There are also times in our organization when we would like to allow contributors to merge pull requests without review whenever checks would be passing but not to allow direct push to protected branches. 

Ground Controller Lvl 1
Message 35 of 35

Re: Do not require owner approval if the pull request is from an owner?

Do you guys know of any workaround for this issue?

I'd like code owners to be able to merge/review their own PRs too.