Help
cancel
Showing results for 
Search instead for 
Did you mean: 
Moderator
Message 21 of 33

Re: Do not require owner approval if the pull request is from an owner?

Hi @leekocytes


If you haven't already, please write us privately at support@github.com so we can take a look for you.

 

Thanks!

Mark helpful posts with Accept as Solution to help other users locate important info. Don't forget to give Kudos for great content!

Ground Controller Lvl 1
Message 22 of 33

Re: Do not require owner approval if the pull request is from an owner?

We are experiencing this issue on GitHub enterprise, what is the reccomended course of action? Would like a fix as this is quite prohibitive.

Moderator
Message 23 of 33

Re: Do not require owner approval if the pull request is from an owner?

Hi @rich4756,

 

As mentioned in previous comments, please write us privately at support@github.com so we can take a look for you.

Mark helpful posts with Accept as Solution to help other users locate important info. Don't forget to give Kudos for great content!

Ground Controller Lvl 1
Message 24 of 33

Re: Do not require owner approval if the pull request is from an owner?

We are also experiencing this issue. I will write to support@github.com, but it definitely sounds like a universal issue - again, given all the folks who have messaged here...

Ground Controller Lvl 2
Message 25 of 33

Re: Do not require owner approval if the pull request is from an owner?

This is obviously an issue that affects everyone ? how many people do you expect to email you about this ?

Can't a workaround or fix  if any be published so everyone is aware and can test ??


Copilot Lvl 2
Message 26 of 33

Re: Do not require owner approval if the pull request is from an owner?

Same issue here - would like code owners to be able to approve their own PRs without approval from anyone else.

Ground Controller Lvl 2
Message 27 of 33

Re: Do not require owner approval if the pull request is from an owner?

@lee-dohm  Any update for this fix?

Community Manager
Message 28 of 33

Re: Do not require owner approval if the pull request is from an owner?

It is currently the expected behavior that code owners cannot review their own pull requests. There was a bug that prevented a pull request from being reviewed by anyone if it was submitted by a code owner. That bug has been fixed. There is currently no update on when or if a code owner will be able to review their own pull requests.

Ground Controller Lvl 1
Message 29 of 33

Re: Do not require owner approval if the pull request is from an owner?

Thanks for the bugfix but I want to emphasize that a designates code-owner should be able to either review his own pull-request or just merge it like the admin can do because, as of now, there is no way to collaborate within a small group and have one code owner (that is not an admin) who is responsible for merging pull-requests.

 

The only way around this is to let the desired code-owner create the repository (which spawns a bunch of other problems) or to let the admin merge the pull-requests of the code owner which is a problem when the code-owner wants to merge something and the admin is not there to instantly merge the pull-request.

 

Every update regarding this is very much appreciated :)

Ground Controller Lvl 1
Message 30 of 33

Re: Do not require owner approval if the pull request is from an owner?

We have around 100 license seats for github and a lot of different code owners for different modules of the same codebase. I'd really like to be able to exempt codeowners from requiring *other* codeowners to review their PR if it's in their own area.

A code owner is a person who understands the area well enough to tell others how it should work so it's doesn't make sense that they require another, different codeowner in the same area to review their PR. They should just have the standard review and build rules applied to them.