Help
cancel
Showing results for 
Search instead for 
Did you mean: 
Copilot Lvl 2
Message 1 of 4

Broken ordering of commits in PRs

We just realised that commits in a pull requests are visualized in the chronological order of their creation, rather than their actual commit order in the branch that should be merged. See

    https://github.com/siemens/meta-iot2000/pull/102/commits vs.

    https://github.com/andi8086/meta-iot2000/commits/integration7.

 

I'm a bit surprised to find such a fundamently issue in this prominent feature - or is this a recent regression of the UI?

3 Replies
Commander Lvl 3
Message 2 of 4

Re: Broken ordering of commits in PRs

The order of creation === the order of how they should be merged? Or am I seeing something wrong here?


- Mark
Copilot Lvl 2
Message 3 of 4

Re: Broken ordering of commits in PRs

When merging a branch, the actual order in that branch defines the merging order. That may differ (like in this case) from the creation order of a commit if you used git rebase on that branch prior to publishing it. That's in fact a pretty common workflow when designing clean patch queues in a logical (rather than just chronological) order.

Copilot Lvl 2
Message 4 of 4

Re: Broken ordering of commits in PRs

It also has been hapenning to me for at least a few days. Fixing up old commits makes the visual order in github wrong. Hope this problem resolves soon.