GitHub Community
Why is "diff" rendering endpoint better for SVGs than "added" rendering endpoint? #22692
-
|
If you compare this diff using the added endpoint and this diff using the diff endpoint, the second displays much better. The second link shows a buggy and unviewable diff… So why has Github not consolidated the endpoints? |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments
-
|
Hi @lmn8! 👋 I’m not sure I understand what you mean - you say “The second link shows a buggy and unviewable diff” but presumably you mean the first link? I think this is due to what’s being shown? The first link is looking at all commits, so is comparing the initial state with no icons to the final state of the PR, with the chosen icons. Since there’s only one version of an image, you don’t see the options to do with diffing images: https://help.github.com/en/github/managing-files-in-a-repository/rendering-and-diffing-images In the second view you’re diffing a subset of the commits that have two different versions of the images, so that’s why you see the fancier image diffing tools. Does that answer your question? |
Beta Was this translation helpful? Give feedback.
-
|
Yes! I think new SVG icons without a “height” and “width” should really be rendered 150px by 150px for consistency & convenience. |
Beta Was this translation helpful? Give feedback.
-
|
Oh, I see! We’re always working to improve GitHub, and we consider every suggestion we receive, so perhaps you’d like to submit a feature request through our official product feedback form so that our product team can see exactly how you’d like image diffing on GitHub to work? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for adding the feature. This thread probably can be closed now |
Beta Was this translation helpful? Give feedback.
Oh, I see! We’re always working to improve GitHub, and we consider every suggestion we receive, so perhaps you’d like to submit a feature request through our official product feedback form so that our product team can see exactly how you’d like image diffing on GitHub to work?