Hello folks!

The problematic (may be an issue/bug) : When I merge a PR from a branch to master (default) or synch a branch from master, in my action workflow, I’m getting a “push” event, but I’m expecting the “pull_request” one

For you to get an overview of the git structure flow I’m using, here it is :

• We have 3 branches, develop, staging and master (which is the default branch)
• The merge flow is develop → staging → master
• CI/CD triggers on closed and merged PR from develop → staging, and also when PUSH on master (hotfix scenario), condition below :

job-name:
  if: (github.event.pull_request.merged == true && github.event.pull_request.head.ref == 'develop') || github.event_name == 'push'

• CI/CD workflow automatically build docker images if files within a given directory are edited

So far, PRs from develop to staging (and reverse for sync) trigger the expected event and workflow job, I’m getting github.event_name : "pull_request" and github.head_ref : "develop" or "staging", depends if its a sync or not", which I use in my job condition (if)

But when it comes to PRs from staging to master, I’m expecting the same event (with github.event_name : "pull_request" and github.head_ref : "staging") but I’m getting “push” instead, which triggers the action also on master branch, which breaks my CI/CD control structure. It shouldn’t trigger, according to the condition (if) above and the expected event.

And “push” events doesn’t seem to include any value I can use to detect whether it comes from staging or master itself, except for the PR commit name but I don’t want to rely on names which can change over time.

Is every “pull_request” event followed by a “push” one? Because I’ve been trying the following and got two events, so two running workflow when PR staging to master :

on:
  pull_request:
    branches:
      - 'staging'
      - 'master'
    types:
      - closed
      - synchronize # Not used yet, but could be useful for pre-test checks
    paths:
      - '.github/workflows/generic-docker.yaml'
      - 'service-one/**'
      - 'service-two/**'
  # Hotfix process when pushing directly to master
  push:
    branches:
      - 'master'

Am I misunderstanding some points here, I’ve been searching documentation on this, but still no luck…

The workflow file :

on:
  # Clean process flow when merging branches
  pull_request:
    branches:
      - 'staging'
    types:
      - closed
      - synchronize # Not used yet, but could be useful for pre-test checks
    paths:
      - '.github/workflows/generic-docker.yaml'
      - 'service-one/**'
      - 'service-two/**'
  # Hotfix process when pushing directly to master
  push:
    branches:
      - 'master'
    paths:
      - '.github/workflows/generic-docker.yaml'
      - 'service-one/**'
      - 'service-two/**'
jobs:

generic-docker:

runs-on: ubuntu-latest

if: (github.event.pull_request.merged == true && github.event.pull_request.head.ref == 'develop') || github.event_name == 'push'

steps:

# Run specific steps depending on which files changed

# ...

Does anyone have a clue on how I could solve this, in a reliable way? Thanks for reading!

Thanks!