This workflow is awaiting approval from a maintainer

What is this? Afaict, there is no alt / replacement text for these :warning: widgets (or really, anything in this column, which is really :100:% bad from an a11y perspective).


discourse/discourse – Tests #1869
Tests workflow run required action for label-for-alias branch
@jsoref ci activity

discourse/discourse – Linting #1869
Linting workflow run required action for label-for-alias branch
22 minutes ago @jsoref ci activity

discourse/discourse – Ember CLI tests #880
Ember CLI tests workflow run required action for label-for-alias branch
22 minutes ago @jsoref ci activity

discourse/discourse – Linting #1868
Linting workflow run required action for spelling-db-migrate branch
27 minutes ago @jsoref ci activity

discourse/discourse – Ember CLI tests #879
Ember CLI tests workflow run required action for spelling-db-migrate branch
27 minutes ago @jsoref ci activity

discourse/discourse – Tests #1868
Tests workflow run required action for spelling-db-migrate branch
27 minutes ago @jsoref ci activity

If it’s trying to tell end users that a repository maintainer (i.e. not them) needs to do something before something happens, this seems like entirely the wrong method and message for this purpose.

Red Alerts should really be restricted to things for which the user is capable of fixing.

There is also afaict 0 user facing documentation on this topic.


More on the color issue:

:warning: 3 workflows awaiting approval

First-time contributors need a maintainer to approve running workflows. Learn more.
2 successful checks

Afaict this is an associated object. Do note that it is colored Yellow. I do not see any reason that the corresponding :warning: items in Notifications are red.

While there is a page Approving workflow runs from public forks - GitHub Docs it does not document the end user experience, and it isn’t going to be found anyway, as "First-time contributors need a maintainer" - Google Search does not turn up GitHub.

It’s to combat cryptomining spam which can hamper your repo: GitHub Actions update: Helping maintainers combat bad actors - The GitHub Blog

Ok. That explains the reason that GitHub did something.

It doesn’t cover:

  • Why there’s no documentation for this message
  • Why the images don’t have alt text
  • Why the :warning: is red instead of yellow

Why should the user who is making a mining pull request receive a red alert? What do they care that their effort to steal from the cloud is blocked?

Why should a user trying to make a constructive pull request care that some tooling, about which they’re almost certainly unfamiliar with, isn’t running?

None of this justifies a red notice. Heck, it barely justifies a notice at all.

I’ll add another thing:

  • How does a user opt out from this notification?

    I got perhaps a dozen. And that was within a couple of minutes. In case it isn’t obvious, I don’t need or want such notifications. They are a waste of my time. When a project runs their tests and things fail, that’s something I need to know about. Until then, I have better things to do.