-
This is something I’ve wanted for a while but seems even more useful now due to the Docker Hub pull limit changes (see this post, I’m mainly referring to the linked GitHub issue). Many people input their Docker repository username as a secret. This can be useful as you can:
But, when you’re doing something like maintaining a library, you are often using Docker Hub and the same username to push (and even pull in the future) as the Docker Hub repository owner. Using a secret results in unnecessary censoring which could make logs quite difficult to read. If you end up switching to a designated account or use something like Google Container Registry, you would want to switch to a secret as the username may be sensitive, but the only way to do both of these things is to initially have it hard coded into the workflow (e.g. an env var) then commit a change switching it to a secret. Initially using a hard coded value loses the first advantage mentioned above. I was initially thinking of a separate settings-like tab where you could enter variables (which wouldn’t simply be passed into every workflow and step and instead behave similarly to secrets), but having a toggle in the add secret input would make more sense, be less confusing, make it more visible and have it be very similar to an existing setup (no referencing non-censored variables as a secret in the workflow). Having a tick box when adding/editing a secret which marks it as non-sensitive (meaning it is not censored in logs) along with some indication in the secrets list that it is not censored (and maybe even showing the existing value when editing it/allowing users to see the value of it without resetting it) would help make logs more readable in some cases and allow for the benefits of secrets to be used for more things. There are probably more examples than Docker usernames which would also benefit from this feature. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments
-
Thanks for your feedback. GitHub takes your suggestions very seriously, and the suggestions are very helpful for improving GitHub. I recommend that you can directly share your suggestion here. That will allow you to directly interact with the appropriate engineering team, and make it more convenient for the engineering team to collect and categorize your suggestions. |
Beta Was this translation helpful? Give feedback.
-
Thanks, I’ve submitted it there. Out of interest, was this policy changed recently? I wanted to avoid posting this in the wrong place but this post suggested posting on the forums is fine too |
Beta Was this translation helpful? Give feedback.
-
About where you need to post your topics, you can reference “Contacting support”. |
Beta Was this translation helpful? Give feedback.
@nihaals,
Thanks for your feedback.
GitHub takes your suggestions very seriously, and the suggestions are very helpful for improving GitHub.
I recommend that you can directly share your suggestion here. That will allow you to directly interact with the appropriate engineering team, and make it more convenient for the engineering team to collect and categorize your suggestions.