Rails feature tests have stopped running javascript #25683
-
Having been happily using GitHub Actions to run my Rails/Rspec/Capybara tests for many months, it has now just stopped working! The pipelines started failing on builds on 26th Aug, around 1200 GMT. Any test that requires JavaScript to run fails, eg :
The problem can be isolated from our code by looking at previous merges to our repo. Our config:
|
Beta Was this translation helpful? Give feedback.
Replies: 7 comments
-
Thanks for your feedback.
IanVaughan:
Do you mean it worked normally before, but now it fails? If so, did you make any specific changes in your code? |
Beta Was this translation helpful? Give feedback.
-
niconbw:
Yes, it was working and now it’s failing, but, as I say, fails for previously passing (unchanged) builds.
niconbw:
As I say above, previous merges to master that passed at the time are now failing on re-runs.
niconbw:
Unfortunately not this is a private repo, but unless you are an employee of GitHub, I don’t see what looking at the repo will show you, because as I say, no changes in our repo have caused this change. |
Beta Was this translation helpful? Give feedback.
-
Hi @IanVaughan |
Beta Was this translation helpful? Give feedback.
-
The issue has solved itself! At a guess, a gem update has helped, but the fact that no gem update was made to cause the issue still concerns me. Sorry I was unable to find time to create a public repo, but thanks for your help in any case. Ian FWIW changes since raising this report:
|
Beta Was this translation helpful? Give feedback.
-
This has just started failing again, even on previously passing builds, all the tests pass locally. Having to run without feature tests on CI now, hoping that all the team run a complete test run before pushing!!
Last time this fixed itself after a few days, so I guess whatever was changed on the runner or VM was either rolled back or updated? workflow yml and runner log output: runner.log · GitHub Also raised issue here Rails feature tests have stopped running javascript feature tests · Issue #3548 · actions/virtual-environments · GitHub |
Beta Was this translation helpful? Give feedback.
-
We found the issue, a cleaver colleague than me, dig into the logs and spotted 2 issues, the first I think being the cause.
1.1 The fix was to set
2.1.
|
Beta Was this translation helpful? Give feedback.
-
I can confirm that disabling Spring indeed fixed the issue. Thanks a lot @IanVaughan for sharing! Something like this would’ve easily killed a few days.
|
Beta Was this translation helpful? Give feedback.
We found the issue, a cleaver colleague than me, dig into the logs and spotted 2 issues, the first I think being the cause.
1.1 The fix was to set
DISABLE_SPRING: true
in GitHub actions2.1.
test.js
hasn’t changed for nearly a year, but JS libraries have been upgraded each week.2.2 The fix was: