GitHub Community
Pull requests merged through the API are not auto closing issues (closing keywords) #24869
-
|
Hi I have a probot app that merges pull requests once all CI statuses succeed. Some users reported that the pull requests merged with the bot are not triggering closing issues with keywords. I could reproduce it with this pull request and this issue. Is closing via API supposed to behave as closing via web? |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments
-
|
The mystery has been solved 🎉 After playing back-and-forth, even trying some non-sense stuff. I found the problem! \ The bot needs issue write permissions, otherwise closing issues using keywords will “fail silently” (╯°□°)╯︵ ┻━┻ |
Beta Was this translation helpful? Give feedback.
-
|
Hey @phstc, Thanks a lot for being here, we appreciate you coming back to share your solution. |
Beta Was this translation helpful? Give feedback.
-
|
We’re observing the same issue, but with the Mergify app. Which does seem to have issue write permission, so I’m stumped as to how to solve this… |
Beta Was this translation helpful? Give feedback.
-
|
Hi @mboes If the problem is with permissions you may be able to see some specific errors in the logs. |
Beta Was this translation helpful? Give feedback.
-
|
Turns out this was the same problem as for you. It’s been fixed by upstream since a couple of months ago. See Mergifyio/mergify#466 (comment). |
Beta Was this translation helpful? Give feedback.
The mystery has been solved 🎉
After playing back-and-forth, even trying some non-sense stuff. I found the problem!
\
The bot needs issue write permissions, otherwise closing issues using keywords will “fail silently” (╯°□°)╯︵ ┻━┻