PR multiline review

Hi!

Sorry for probably a silly question, but is there a way to select multiple lines while reviewing a pull request? Currently I can only see a blur plus sign which selects only one line.

Thanks,

Alex

4 Likes

Hi @alexbagirov,

At this time, there is not a way to highlight multiple lines to add a comment on a Pull Request review. However, you can select multiple lines when looking at the file on the branch that the Pull Request is based on and then select Copy Permalink which will give you a link to those selected lines as you can see here:

Screen Shot 2018-04-29 at 4.10.39 PM.png

Then when you copy that link into a review comment, it will be rendered as those lines of code. That way, you can comment beneath the relevant place in the code but still indicate all of the lines you’re referring to.

Does that help?

5 Likes

Will this continue working if you delete branch after merge?

Hi @llamerr,

Yes, the link will still work after the branch is deleted.

Thanks!

What about a whole new file? How can I do it there? I cannot see the ... thinggie… 

1 Like

this may be a dumb question but, how do I select multiple lines?

@danielrvt wrote:

this may be a dumb question but, how do I select multiple lines?

When in diff vew, click the ‘…’ in the right hand corner of a file and choose ‘View file’. This will open that file in the new branch. Then click on the first line you want to select, hold shift and click on the last line. Then copy-paste the whole url into your comment on the PR, or press the ‘…’ by the first selected line and choose ‘Copy permalink’.

1 Like

Good news: github has just launched the feature. Now you can highlight multiple lines in a pull request diff and add a comment, all at once.

https://twitter.com/github/status/1179101186437324801

3 Likes