New commits not showing in PR

Hi,

When we were trying to merge the following pull request (https://github.com/emieldesmidt/trustchain-superapp/pull/11), but there were merge conflict which we had expected.

So I fixed this merge conflicts and pushed them to the branch (https://github.com/emieldesmidt/trustchain-superapp/pull/11). The strange thing is that the commits are showing on GitHub in the branch, but the commits are not showing in the PR and now we can’t merge!

When I create a new PR, the commits are actually showing, but shouldn’t they also be shown in the original PR?

Does anyone know if this is a bug or are we doing something wrong?

2 Likes

@praveshmoelchand wrote:

Hi,

 

When we were trying to merge the following pull request (https://github.com/emieldesmidt/trustchain-superapp/pull/11), but there were merge conflict which we had expected.

 

So I fixed this merge conflicts and pushed them to the branch (https://github.com/emieldesmidt/trustchain-superapp/pull/11). The strange thing is that the commits are showing on GitHub in the branch, but the commits are not showing in the PR and now we can’t merge!

 

When I create a new PR, the commits are actually showing, but shouldn’t they also be shown in the original PR?

 

Does anyone know if this is a bug or are we doing something wrong?

Thanks for raising this here! It’s interesting behavior to report that the new commits resolving the merge conflict aren’t reflected in the timeline.

However, I’m not quite sure how to reproduce this. Are you able to reliably reproduce this behavior in a public test repository independent of this case? I’d be interested in reviewing that example before passing it on internally for our engineering team to investigate further.

1 Like

We are having the same issue in Ouranosinc/xclim#500.
If you go and look:

  • Commits up to 3b31121 were working correctly.
  • Then all commits up to aac981f (included) did not appear in the PR when they were pushed.
  • Committing 918bf03 or b917679 unblocked the problem and the PR was updated (I don’t know which one worked, sorry)
  • Since then, all newer commits in the branch also do not appear in the PR.

EDIT: Now all the commits appear in the PR. So it seems that there is a lag between the commit push and their appearance in the PR. Or more precisely, that the PR is not updated live, rather it updates everything after some time.

I guess this happens from time to time. Glad I wasn’t the only one seeing this issue.
Pushed a commit from a forked branch, created a PR to merge to the original branch, PR looked fine. Made a second commit to the forked branch, expected the PR to be auto-updated but the 2nd commit didn’t show up until 30 minutes later and until after I had read this thread : )

@nathanlemma likely related to the incident earlier today: https://www.githubstatus.com/incidents/j4vrg2ljjb5c