Merging linked PRs did not closes the associated issues #27044
-
Hello, For some reason, the repo I’m maintaining will not automatically closes issues that were linked with a PR. I made sure that the PRs are properly merged into our default branch but it still doesn’t happen. Here’s the issue in our repo. Here is its content: BugMerging a linked PR into the How to replicate the bugMake an issue and make a PR. Link those together and merge the PR into Possible Fixes/SolutionsNot sure. Here’s what we’ve tried:
My next move will be making a thread about this on the Community website. Hopefully, we’ll get an answer there Note:
Others (like this) don’t: Both are issues that should have been closed automatically |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments
-
How were those PRs linked with the issue? I’m not seeing any “Closes: #592” or similar in the description, and at least for the one merged PR that’s listed as linked I also looked at the commits in it and didn’t see any such tag either. |
Beta Was this translation helpful? Give feedback.
-
Hi, From what I understand in this link, as long as “closes #issue_number” is in one of the PR comments, it should be linked. See also this. The contributor made sure to have the keyword within the description and as a commit message as wel |
Beta Was this translation helpful? Give feedback.
-
I noticed the PRs for the issues you’ve linked were all merged into |
Beta Was this translation helpful? Give feedback.
-
It’s a bit annoying that GitHub won’t close the issue later when the commits eventually get merged into Thank you for your response though |
Beta Was this translation helpful? Give feedback.
-
I assume that would work if you didn’t use squash merges. That way the commits with the “closes” tags would end up on |
Beta Was this translation helpful? Give feedback.
I noticed the PRs for the issues you’ve linked were all merged into
develop
, which is not your default branch. That explains it. The PR must be merged into the default branch to close issues. 🙂