GitHub Community
Matrix variable does not work in needs keyword #25364
-
|
I have a build matrix over a certain amount of build types. Then I want to create a job that tests those builds but each test job depends on the build of the same type so I tried: However this results in an error saying Is there a way to create a template like this given we cannot templatize the needs keyword? |
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 2 replies
-
|
Github workflow yml doesn’t support use ${{matrix.xx}} in needs keyword. I would suggest you to specific all jobs name into the matrix job > needs keyword. For example， you have jobs: build-normal , build-extra and build-nox. In test job with matrix, set Then the matrix jobs will start after all the dependences jobs completed. |
Beta Was this translation helpful? Give feedback.
-
|
That will work but it’s not perfect as it will delay the workflow since if build-normal is faster to run than build-extra, test-normal should start straight after build-normal and not only after all build types have finished. I understand this is a limitation and therefore will accept your answer. |
Beta Was this translation helpful? Give feedback.
-
|
You can simplify it to just specify needs: [build], but yes I haven’t found out a way to for it to start the next job until ALL of the matrix jobs have complete. Has anyone else? |
Beta Was this translation helpful? Give feedback.
-
|
Hum, I am confused and I am getting a different behaviour where GitHub Action waits for all builds to be finished before moving. https://github.com/comit-network/comit-rs/runs/611097751?check_suite_focus=true As you can see here: https://github.com/comit-network/comit-rs/blob/924964c5ec07aa189d885ad36dd5e60f7166f76e/.github/workflows/ci.yml#L94 I have When I actually would like, similar to OP, to start the second step whenever the first step is done for a given value in the matrix. |
Beta Was this translation helpful? Give feedback.
-
|
Same confusion over here. Just because the Windows runner is slow I shouldn’t have to wait for test feedback on the Linux runners. 😕 In fact, why can’t we set a strategy/matrix for the whole workflow? That could implicitly solve this issue (in some cases), since then (or so I would imagine) all job names are scoped to the current matrix entry. |
Beta Was this translation helpful? Give feedback.
-
|
3 years later and we still do not have an answer. |
Beta Was this translation helpful? Give feedback.
-
|
It would be really useful to be able to start linux tests before the very slow mac runners are done. Is there any way to make that work? |
Beta Was this translation helpful? Give feedback.
-
|
Maybe with reusable workflows, here is an example what I mean ./.github/workflows/main.yml on: push
name: build and test
jobs:
build-and-test:
strategy:
matrix:
os:
- windows
- linux
- macOS
uses: ./.github/workflows/build-and-test.yml
with:
build-config: ${{ tojson(matrix) }}.github/workflows/build-and-test.yml on:
workflow_call:
inputs:
build-config:
type: string
jobs:
build:
strategy:
matrix:
include:
- ${{ fromjson(inputs.build-config) }}
runs-on: ubuntu-latest
steps:
- run: echo "$MATRIX"
env:
MATRIX: ${{ tojson(matrix) }}
test:
needs: build
strategy:
matrix:
include:
- ${{ fromjson(inputs.build-config) }}
runs-on: ubuntu-latest
steps:
- run: echo "$MATRIX"
env:
MATRIX: ${{ tojson(matrix) }}This example imports the global matrix configuration into the The test job for linux only depends on the build job for linux and are run truly parallel with static needs. If you are using GHES, matrix strategy for reusable workflows might be still unavailable and you have to wait for a GHES upgrade |
Beta Was this translation helpful? Give feedback.
-
|
Thanks. It didn't work for me exactly as that, but it helped me on the way. In order to make this work, I had to separate into build-mac, build-linux jobs. I then also have a test-linux and test-mac job which uses the needs keyword for the required build job. Then each of the jobs simply sets up the matrix at the top level, and uses the reusable workflow for building, or testing, to keep things short. I also opted for explicitly passing each matrix value to the reusable workflow, and not have a separate matrix setup there, as I didn't get that to work properly. |
Beta Was this translation helpful? Give feedback.
Github workflow yml doesn’t support use ${{matrix.xx}} in needs keyword. I would suggest you to specific all jobs name into the matrix job > needs keyword.
For example， you have jobs: build-normal , build-extra and build-nox.
In test job with matrix, set
Then the matrix jobs will start after all the dependences jobs completed.