Issue label lozenge colours changed

I noticed the colours for issue labels changed. Is this a side effect of the introduction of dark mode? The colours changed for light mode, too.
The problem is that text is not readable on lozenges with darker colours anymore.

1 Like

@flaix are you using any browser extensions for GitHub? We’ve seen some issues with customers using the refined-github extension for example. The colors should not have changed for light mode, though due to how we dynamically calculate contrast for alpha in dark mode the colors could look visually different when in dark mode. If you’re not using an extension can you share a screenshot so we can investigate? Thanks!

I am not using any extensions for github, simple firefox browser as always. I’m not using any theme, either, just the default I’ve been using for several years.

The problem I am seeing is that the text color is ALWAYS BLACK. It used to be that if I chose a color wth low luminocity, the text would change to WHITE. This made it readable. But for the vast majority of colors, black text will NOT work, especially when people NEED HIGH CONTRAST. You know, like people with OLD eyes.

It’s actually an “accessibility” thing.

All we need is one of two things:
a) fix it so it works the way it used to (text automatically becomes white when dark luminocity colors are used)
b) let us change the text color for a label as well as the background [even better].

In any case I’ll end up re-doing EVERY label, including the default ones, because of this change in behavior. Not what I wanted to spend time on, ya know?

2 Likes

Sorry you’re also experiencing this @bombasticbob! I’ve had to go through and redo all the label colors for a repo before (unrelated to dark mode :wink:) so I 100% feel you on not wanting to spend your time fixing this…
But this should definitely not be happening and seems to be a weird bug affecting some users. I just shared this with the team to review

I am not using any browser extension either. The problem is, as bombasticbod described, that the text is always dark grey. It actually looks like the colours also changed, but that may be just a visual effect of the text color change and the added frame.

Now:
GitHub-LabelColor-new

This is with Safari on macOS Mojave. I just opened an issues page with Firefox, and there the text is still white.

This is what it looked like before:

GitHub-LabelColor-old

I had to put it into a new post, due to forum restriction.

Thank you @flaix and @bombasticbob for the report. Could you provide specifics on browser versions and os versions?

macOS Mojave 10.14.6
Safari 13.0.5 has dark grey text and border around lozenge
Firefox 83.0 has white text and no border

Ah, ok. We were using a bit of CSS that Safari doesn’t get support for until 13.1. I have a fix coming that should fix for Safari, but won’t be able to deploy it until our code freeze is over next week.

To get a fix faster, If upgrading your browser is an option, I would suggest upgrading to at least Safari 13.1.

Ok, cool. I could wait for a fix, since you already have one. The only thing keeping me from updating Safari is the amount of open browser tabs I’d lose. :slight_smile: But I guess it is high time to upgrade to version 14, in general, so maybe this will be reason to finally do that.
Thanks.

:joy: Totally valid reason. From one tab addict to another, this History option has saved me a few times when my browser crashed.

Hm, ok, ok, I’ll give it a shot, either later or tomorrow, when GitHub Universe is over. :slightly_smiling_face: Thanks!

1 Like

I’m using FreeBSD 12-STABLE and Firefox 70.0.1 on this machine. (keep in mind that updating things on FreeBSD can be a non-trivial process, though it is AWESOME as a development platform and stability, over bleeding-edge, is generally a VERY good thing). This version of firefox is from the 2019Q4 ports collection as I recall.

I also tested it with chromium version 78.0.3904.87 . Same problem.

On a hunch I tested it using firefox 78 on the latest Devuan. Seems to work as expected there, i.e. white text on a dark red color for labels, black for light colored labels.

uname says this: 4.19.0-12-amd64 #1 SMP Debian 4.19.152-1 (2020-10-18) x86_64 GNU/Linux

Apparently the style sheet changes aren’t compatible with 1-2 year old firefox code. That’s more than a bit disturbing, actually…

Just to mention, on very stable “I am trying to get work done” systems, it is common NOT to constantly update them. this is especially true with servers, which may get security updates, but very few software version updates. Additionally many Linux distributions will stabilize software versions at a specific point. Debian is infamous for this, sometimes being 2 or 3 years behind ‘bleeding edge’ but it’s very very stable.

So I would ask very nicely that these changes be tested on older browsers, please, especially if they’re LTS versions or are shipped as part of Linux distributions that have LTS support.

I upgraded to Safari 14.0.1, and at least for me that fixed the issue. Text colors are now back to normal.

1 Like