Skip to content

How can I deal with not approved pull requests with feature dependencies? #22810

Discussion options

You must be logged in to vote
Zaldivar97:

Should i create a new local branch upon feature A instead of develop ?

That would be common practice, yes. Two things to be aware of:

  1. If branch A is rebased (including rebase-merge), or squash-merged into develop your branch B will contain commits originating from branch A that probably shouldn’t become part of history. You’ll have to clean that up before merging branch B into develop.
  2. Similarly, if there is still development (as in, new commits) on branch A you might have to merge them into branch B, or rebase B, to make sure you have the latest state. Technically you could keep developing B and look at the differences when it’s time to merge, but usually it’s easier to…

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants