Github Review Workflow

Our company might be moving from Bitbucket to Github. 

We have a pretty cool PR workflow in Bitbucket. Usually we create a work-in-progress PR after the first few commits, and the one working on the code adds his TODOs directly as PR tasks to the according lines of code or to the PR if there is no line of code. Once other reviewers join, they can also create general tasks, tasks associated to files or tasks associated to lines of code, either for the whole diff, or only a single commit in the PR.

https://blog.bitbucket.org/2014/09/16/introducing-pull-request-tasks/

Combined with “Iterative Reviews”, the PR workflow is very convenient and easy to use, as we can choose to only review diffs between the last time we reviewed the PR and the newest commit.

https://www.atlassian.com/blog/bitbucket/new-features-bitbucket-4-11

Also in the file list I see which files I have already reviewed and which ones have been changed since I last reviewed them (filename in bold).

Now in Github I’m completely stumped and confused by the PR workflow. Are the things I described above possible in Github too? How? I don’t get that “Start Review” interface. How can I just create a PR task for a specific line of code, that needs to be fixed before the PR can be merged?

Thanks.

1 Like

To review a PR, you should go to the “Files changed” tab, and you can add comments to any line in the changed file, you just need to press the “+” button which appears on the left side of a line when the mouse is over that line. When you finish reviewing the PR, you just need to press the “Review changes” button on the top right, which will open a dropdown so that you can choose to approve, request changes, or comment without approving or requesting changes. For tasks you can use task lists: https://help.github.com/articles/about-task-lists/.

1 Like

So I read from that, that it’s  not possible to use some sort of tasks like in Bitbucket. That’s sad.

The task list of Github is only possible in the first comment => not possbile for reviewers to use.

I like to have tasks that can be checked off for code/general findings of other reviewers or myself. When someone does a review, it does not produce tasks that need to be checked off before the PR can be merged.

The workflow of first adding code comments, which do not get visible until I select “Submit Review” is very confusing and complicated.

Hi @fabb,

Thanks for this feedback! We’re always working to improve GitHub, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.

Please let me know if you have any other questions.

Cheers!

1 Like