Github "Changes requested" in an PR completely misleads

Hello,

GitHub’s “Changes Requested” message makes it hard to review changes that were already made based on a reviewer’s message.

https://github.com/ARM-software/lisa/pull/492#issuecomment-377962295

The confusion is for 2 reasons:

  1. The commits from the Changes requested (that were made to address the request) appear BEFORE the “Changes Requested” message.

  2. The Changes Requested is big bold and red.

Any chance we can fix this so its more meaningful? The latest commit updates should appear at the bottom. So if I scroll to the bottom of the page, it should show the changes/commit made to address the request, and the tone of “Changes Requested” should be reduced.

9 Likes

Hi @joelagnel,

Thanks for this feedback! We’re always working to improve GitHub, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.

Please let me know if you have any other questions.

Cheers!

1 Like

I agree that big red letters of “Changes Requested” doesn’t really look nice when the changes are already done.

Maybe another possible solution is to have a “Changes Implemented” state which the author of the change can set when the author feels that the changes are done as requested.

19 Likes

After a PR author clicks the refresh icon button to ask a reviewer to re-review the pull request, the PR status remains as “Changes Requested”.

As the reviewer, I do see the PR now on https://github.com/pulls/review-requested so I can use that for my workflow.
However if I’m on the repo page “Pull requests” tab there’s no indicator as to which PRs are ready for re-review. I think you should indicate this somehow.

Thanks in advance.

4 Likes