GitHub Actions: Continuous Integration [Stuck on step #17]

Hello folks.

I’m completely stuck in step #17. I didn’t use the comment “hint” (I didn’t notice that this MUST be this exact word) and now I don’t know how to move forward nor fix it. It is a mess. I tried to revert the PR but didn’t work, tried to add a new comment “hint” and didn’t work as well.

So, I ran out of ideas. Anyone?

I found your repo on your profile. I see that for step 17 it wants you to use the action that adds labels when a certain number of approvals are added. It gives you a link to that action’s repo which explains how to to use it.

Your workflow, right now, is the following:

name: Team awesome's approval workflow
on: pull_request_review
jobs:
  labelWhenApproved:
    runs-on: ubuntu-latest

So this isn’t using the action right now. It has no steps yet. You need to add to this to use that action.

But I went through this and in my screen shows that the PR is closed.

It is very confusing what I am supposed to do in the 17th step. And I don’t get what you mean here “So this isn’t using the action right now. It has no steps yet. You need to add to this to use that action.

The instructions tell me that I have to do that on my own. That’s is not going to happen: I don’t know what I am doing and there is an Ocean of tech terms, links, menus, text inputs to fill, pick or click. In fact, I am lost.

Steps 15 and 16 give you those 5 lines of code to get you started. So far, you’ve created a new workflow that consists of those 5 lines of code.

Step 17 wants you to be more independent and use what you’ve learned so far about using actions to add the label-when-approved-action (https://github.com/abinoda/label-when-approved-action) to your workflow. It says:

Using your prior knowledge, configure the pullreminders/label-when-approved-action action in this workflow

Because step 17 expected you to commit to the branch team-workflow but you already merged this branch into master, it might be a good idea to delete that branch, create a new branch also called team-workflow and then add the commits you need to that new branch to satisfy the steps up to and including step 17.

The instructions tell me that I have to do that on my own . That’s is not going to happen: I don’t know what I am doing and there is an Ocean of tech terms, links, menus, text inputs to fill, pick or click. In fact, I am lost.

Did you complete the lab before this one in the DevOps with GitHub Actions learning path (https://lab.github.com/githubtraining/devops-with-github-actions)? I started from the beginning before doing the CI lab, and I found the first one helpful.

Now we are understanding each other. This is exactly what I want to do: delete the pull-request, create a fresh one.

Regarding your question about prior labs, this is my first. There is this video from GitHub Satellite 2020 that explains step by step what one’s need to do during the lab. Everything was OK until the 17th step. Then, Prem (I guess this is the instructor’s name) started doing crazy things very fast I could understand or follow.

And here I am…

Note that pull requests cannot be deleted. You created and then merged the PR. It’s in the repo history forever now. But that doesn’t stop you from creating a new branch and doing the PR steps again. Because the lab bot is looking for a PR from a branch with a specific name, I expect that you’d need to follow the steps as I described above to get back to where you need to be, where you are creating a new PR from a branch with the right name.

Not pull-request . Brench! Sorry…

Anyway, the part I have to create a new branch is OK.

Let’s talk about the commits. What are those commits? What are the files I need to change?

The file you need to change is https://github.com/renatospaka/github-actions-for-ci/blob/8d608fa78b69e5ebd6085f8c1835acc0489b7df2/.github/workflows/approval-workflow.yml. The commits you need to make are ones that add using the label-when-approved-action action. The step 17 instructions include a link to its repo, and if you follow the documentation on that repo, you should be able to figure out how to edit your workflow to use it.

Thank you @mattwelke.

However, this was a long day with 10 hours of an online event. Meaning I am tired.

This is why I’m asking you to confirm: all I need to do is to update this file approval-workflow.yml and add a comment “hint” when committing branch team-workflow?

The comment “hint” won’t be necessary, but yes, you just need to make the required changes to approval-workflow.yml. 10 hours sounds like a long day. I’m sure you’ll feel better tomorrow trying again to complete this step. Take a break. :slight_smile:

By the way, I use CircleCI at work (a competing product to this, quite similar) and it took me a good two years to fully understand how to use it for what we need to do. There’s no shame in taking your time to learn this stuff.

Thanks, @mattwelke, I appreciate it.

I just want to finish this step, to have a good night of sleep. You are completely right, I need a break.

Are you from Github Labs Support or just a nice guy trying to help?

Nice guy who likes GitHub Actions. Teaching is a great way to learn and what goes around comes around.

Oh man, I need to apologize to you.

I thought you were from support, so I got straight to the point, no small talk. Once I managed a global Service Center and the best customers were those who were able to go straight to the point, tell what is wrong, what they did and what they expect.

Please forgive me.

Well, I did all over again, committed the file and still isn’t working. Tomorrow I will make this work.

Good night

1 Like