I have a workflow that I have completely built out, only to find out that the actions api doesn’t support “pull-request: approved” (or some variant).
Based on this thread, it seems this is a feature many folks want: https://github.community/t5/GitHub-Actions/GitHub-Actions-Manual-Trigger-Approvals/td-p/31504/highlight/false
None of the current Acivity Types are practical for my use case, and I’m suprised the “approved” activity type is not already supported.
Submit PR -> build triggers -> upon completion a reviewer approves -> upon approval a new action fires off -> merge.
This is very useful for many things, and makes automation simpler. For example – I may want to notify my team in slack that I am merging… I obviously wouldn’t notify before the PR has been aproved.
Well my use case is quite a bit more complex than updating slack – but that is the basic idea. A PR has been approved, and that is a basic GitHub activity that is essential to every developer’s workflow.
Nothing else in the list below will work.
I don’t want our devs typing some magical comment to get things to work, with special regex cases to match every possibility. Same for labels etc.
And the principal idea is “automation”. There are modules to update comments and labels – but what triggers that automatically on approval (which is when we need the action to fire)? The ‘approval action type’ would.