-
I created a workflow which fails if there are unresolved comments on a PR to ensure nothing is forgotten and to make auto-merging easier. It works as expected for new unresolved comments but I can’t find any event which triggers upon clicking the “resovle” button meaning that unless someone triggers the workflow manually it will be hard to get into the passing state consistently. |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments
-
Yes, there is not any events or activity types of the pull_request_review_comment event for resolving the conversation. If your projects really need this feature, I recommend that you can directly report a feature request here. That will allow you to directly interact with the appropriate engineering team, and make it more convenient for the engineering team to collect and categorize your suggestions. |
Beta Was this translation helpful? Give feedback.
-
Thanks, brightran, for trying to see if there were some workarounds. I left feedback for this usecase via the feedback form. I hope as the code review abilities become more mature this type of functionality will be prioritized. :slight_smile: |
Beta Was this translation helpful? Give feedback.
-
Yes, I agree that. In addition, you also can follow the “GitHub public roadmap” repository where you can learn about what features the appropriate engineering teams are working on, what stage the features are in, and when the teams expect to bring them to you. When the new features are published, you can view the release note from “GitHub Changelog”. |
Beta Was this translation helpful? Give feedback.
-
I created the following GitHub Action to prevent the merge of a pull request with unresolved review threads. The flow is far from perfect, but it’s a start! Hope it is of any help! |
Beta Was this translation helpful? Give feedback.
-
Thanks for the update @SamuelCabralCruz. I may try it out. I’ve just been working on this as well using composite actions but I like the idea of using a label to work around the lack of event for comment resolution. One thing to note is that your action may fail for PRs from external forks since GitHub recently restricted those workflows to read only. In the case of adding labels we can use Though the docs are not clear on this so it will take some experimentation. |
Beta Was this translation helpful? Give feedback.
-
There’s a new branch protection in beta which seems to do what I need though I haven’t tested it extensively. I imagine there could be other reasons to have a resolution event trigger for workflows but this seems like it will meet the needs in this thread better than we can do ourselves! |
Beta Was this translation helpful? Give feedback.
There’s a new branch protection in beta which seems to do what I need though I haven’t tested it extensively.
https://docs.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests/about-protected-branches#require-conversation-resolution-before-merging
I imagine there could be other reasons to have a resolution event trigger for workflows but this seems like it will meet the needs in this thread better than we can do ourselves!