Feature request: Drafts of pull requests

I love being able to write drafts of release notes before making a release. I would like to be able to save a pull request description as a draft because I often start writing the description then realize it’s missing something, and I end up copy/pasting that text somewhere else until I’m ready to submit the PR.

Thanks!

28 Likes

Hi @scpeters,

Thanks for this feedback! We’re always working to improve GitHub and the GitHub Community Forum, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.

Cheers!

I, too, would like to be able to save pull request drafts.

6 Likes

This is available now.
https://twitter.com/natfriedman/status/1096094714481106945

1 Like

Its nice that this feature exists now.

I would love to have the ability to convert a pull request that was created as a regular one, to a draft.

EDIT:

Converting PR to Draft is now available as well:

https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/

10 Likes

Thanks for that additional feedback @dannyben! Definitely see the value in that, and I believe you’re not the first to mention it since we launched the draft pull request feature. I’ll make sure that it’s logged in our internal feedback issue for this feature for future consideration!

1 Like

Excellent. I also want to mention that I am creating PRs by using a command line that uses the GitHub API - as far as I understand, there is currently no way to create a PR through the API in draft mode. I have tried applying the “API Preview” Accept header, and sending “draft: true” in my POST request, but it did nothing.

@dannyben The feature should be supported with the GraphQL API, but if you’re using the REST API, this won’t be available (at this time). I just confirmed that there is, indeed, a request logged for support in the REST API and I’ll make sure your feedback is represented there.

1 Like

The visual (grayed out) indicator for drafts in PR list view is not very obvious. Would be nice if it spells out the word Draft below the gray indicator.

2 Likes

Also add the feture to convert a draft PR to a regular one not only by the person that made the PR but also from the team that handles the repository that is receiving the PR

3 Likes

Thanks for the suggestion, @cvvergara! I’ve passed this on to the team working on this project. 

2 Likes

Thanks for the suggestion, @am11! I’ve passed it on to the team who is working on this project. 

2 Likes

@dannyben 

We made such a tool with Go quickly.

Here is our source code.  Hope this helps.

https://github.com/cybozu-go/neco/blob/master/pkg/git-neco/cmd/github.go

Hi,

The new feature to preview pull requests is great.
But during the use of the new feature we ran into some questions:

  1. It seems that just the author can turn a draft into a real pull request. But what if the author is going on holiday and another one takes over the task? Should the Pull request not be changeable by e.g. the assignees and/or admins?

  2. It seems that creating a draft pull request does not end up in the creation off a /pull/*/merge branch. I tried to find documentation about the /pull/*/[head|merge] mechanism, but couldn’t find anything. Will there be a merge branch for the draft already? It would make it easy for us to start our teamcity goals for the draft already as usually you would like feedback before you are ready to get it reviewed :) 

2 Likes