GitHub Community
Feature request: CODEOWNERS without write permissions #23042
-
|
The way our project (https://github.com/OP-TEE) is setup is that we have a set of core maintainers (read/write access) and a set of platform maintainers (read only). So for example when a pull request touches a piece of code belonging to a platform maintainers area the core maintainers asks the platform maintainers for their feedback to decide whether a pull request should be merged or not. When we first heard about the CODEOWNERS features we were pretty excited, since that could automate adding correct reviewers etc, but because of the requirement saying: “The people you choose as code owners must have write permissions for the repository.”, we couldn’t enable the CODEOWNERS feature. What about enabling this so that anyone (with a GitHub account) can be added to the CODEOWNERS file, regardless if they have write permissions or not? // Regards Joakim |
Beta Was this translation helpful? Give feedback.
Replies: 9 comments 3 replies
-
|
Hi @jbech-linaro, Thanks for this feedback! We’re always working to improve GitHub and the GitHub Community Forum, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration. Cheers! |
Beta Was this translation helpful? Give feedback.
-
|
Hi @BelHFL Would it be possible to have an update on this? Thank you, |
Beta Was this translation helpful? Give feedback.
-
|
@BelHFL Could we get an update on this please? Yes, this is definitely a feature that we would like in our organization as well. There is a pretty big difference between "trusted to commit to the whole repo" and "Is the person/team who is responsible for this particular piece of code and knows it the best, to the point where we want to ensure that they always approve things that touch it before they get committed." |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this. Code owners without write access to repo makes a lot of sense when you can't give write permission to a contributor but need their feedback for reviews. |
Beta Was this translation helpful? Give feedback.
-
|
Is there some reason this can't be done? Especially in the case of large monorepos which house multiple components of different ownership (otel-js-contrib for example) requiring write access for CODEOWNERS presents a challenge. As @Bhupesh-V says:
|
Beta Was this translation helpful? Give feedback.
-
|
I hope this gets resolved someday. As an opensource project, we have a multiple collaborators outside of the core team who can help us to maintain code they have contributed. But we can't trust with write access to everyone. Maybe CODEOWNERS for everyone would be hard to implement. But I can see we can now request reviews from any organization team, triage or without any permissions, so maybe changing the requirement from "write permissions" to "be part of an organization" should be more feasible? |
Beta Was this translation helpful? Give feedback.
-
|
@volas At OpenFeature, we've been using https://github.com/dyladan/component-owners, which is also used by a few OpenTelemetry monorepos. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this. |
Beta Was this translation helpful? Give feedback.
-
|
Access to review code is very different than access to write code. This request would honor that difference. |
Beta Was this translation helpful? Give feedback.
-
|
We would love to have this functionality. There are plenty of sections of our repositories that have people who do not have repository write access who are nonetheless functional owners. As we grow bigger, it would be great to have the ability to encode this instead of just relying on people to know it, as that is rather limiting and makes it hard to grow smoothly. |
Beta Was this translation helpful? Give feedback.
-
|
Definitely looking forward to this functionality! |
Beta Was this translation helpful? Give feedback.
-
|
+1 this is something I have only just come to realize can't be done and would be far simpler than the alternative. |
Beta Was this translation helpful? Give feedback.
Hi @jbech-linaro,
Thanks for this feedback! We’re always working to improve GitHub and the GitHub Community Forum, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.
Cheers!