Feature Request: Ability to differentiate a normal comment from a requested change during review


This message from a year ago indicates that “here” (unclear if it’s “that thread” or “the forums writ large”) is the correct place to request features. I could not find another place for this.

Current behavior:

When I am doing a Pull Request review, I can comment on lines of code. Each time I comment, if I have not already started a review, I can either “Add a Comment” or “Start a review”. Once I have clicked “Start a review” the options collapse down to only “Add Review Comment”. When I finalize my review, I have to choose “Comment”, “Approve” or “Request Changes”.

Desired behavior:

When I am doing a Pull Request review, I would like more flexibility in the comments. Sometimes I am giving a review and just want to voice approval for a line or solution the submitter made; I don’t want to request changes on it. At a minimum, I would like the ability for “Add a Comment” to persist even if I have started a review. Instead of “Add Review Comment”, I would like “Request Changes Here”.

Additional Possibilities:

If this were implemented, it would be super cool if each of the “Request Changes Here” could be approved / considered individually as separate from the regular comments.

Rationale :

The gulf of evaluation here is notable – I’ve been using GitHub for about a decade and I’m still not always completely sure how this aspect of things works. What I want is the ability to both comment on code (passively) as well as comment on things I would like changed and being able to clearly differentiate between the two. Also, for the person I’m reviewing to know as clearly as possible what changes are actually needed.

Hi @armahillo,

Thanks for this feedback! We’re always working to improve GitHub and the GitHub Community Forum, and we consider every suggestion we receive. I’ve logged your feature request in our internal feature request list. Though I can’t guarantee anything or share a timeline for this, I can tell you that it’s been shared with the appropriate teams for consideration.