Electron-Builder installers for multi platforms #25177

mandolyte · 2020-03-25T14:53:36Z

mandolyte
Mar 25, 2020

Building an electron app on three platforms. The tool electron-builder will produce installers with names like these two for Ubuntu and Windows:

my-app\_1.0.1\_amd64.deb
my-app Setup 1.0.1.exe

The version string comes its package.json. And I want to run the workflow when I push the tag for v1.0.1.

I have not been able to figure out a way to set the artifact and asset names to contain the version string (not semver).

At the moment, I am hard-coding the version into the workflow itself. Then using action svenstaro/upload-release-action@v1-release to upload the tag.

Here is the start of the workflow and below that is the uploading action.


name:&nbsp;build and release electron from react web  
on:

&nbsp;&nbsp;push:

&nbsp;&nbsp;&nbsp;&nbsp;tags:

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;-&nbsp;'v*'&nbsp;#&nbsp;any push with a&nbsp;tag in semver format

&nbsp;&nbsp;&nbsp;&nbsp;

jobs:

&nbsp;&nbsp;build:

&nbsp;&nbsp;&nbsp;&nbsp;name:&nbsp;build-electron-from-react-web

&nbsp;&nbsp;&nbsp;&nbsp;env:

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;VERSION:&nbsp;1.0.1
&nbsp;&nbsp;&nbsp;&nbsp;#&nbsp;update versions below

&nbsp;&nbsp;&nbsp;&nbsp;runs-on:&nbsp;${{&nbsp;matrix.os&nbsp;}}

&nbsp;&nbsp;&nbsp;&nbsp;strategy:

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;matrix:

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;os:&nbsp;[ubuntu-latest,&nbsp;windows-latest,&nbsp;macos-latest]

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;include:

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;-&nbsp;os:&nbsp;ubuntu-latest

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;artifact_name:&nbsp;book-package-app_1.0.1_amd64.deb

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;asset_name:&nbsp;book-package-app_1.0.1_amd64.deb

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;-&nbsp;os:&nbsp;windows-latest

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;artifact_name:&nbsp;"book-package-app Setup 1.0.1.exe"

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;asset_name:&nbsp;"book-package-app Setup 1.0.1.exe"

The uploading action:


&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;-&nbsp;name:&nbsp;Upload Release Assets
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;uses:&nbsp;svenstaro/upload-release-action@v1-release
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;env:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;GITHUB\_TOKEN:&nbsp;${{&nbsp;secrets.GITHUB\_TOKEN&nbsp;}}
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;with:
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;repo\_token:&nbsp;${{&nbsp;secrets.GITHUB\_TOKEN&nbsp;}}
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;file:&nbsp;"./electron/dist/${{&nbsp;matrix.artifact\_name&nbsp;}}"
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;asset\_name:&nbsp;${{&nbsp;matrix.asset\_name&nbsp;}}
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tag:&nbsp;${{&nbsp;github.ref&nbsp;}}
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;overwrite:&nbsp;true

Answered by weide-zhou

Mar 26, 2020

Hi @mandolyte ,

Thank you for being here!

‘Workflow&Job level env’ and matrix doesn’t accept variables, hence you can set the artifacts/asset name in step level.

2. The version string comes its package.json. And I want to run the workflow when I push the tag for v1.0.1.

>> You can get the tag version from ‘${GITHUB_REF##*v}’, and compare the value in ‘package.json’, use if expression to execute the next steps accordingly.

In total, i assume your script can be changed as below(I removed macos part you can add accordingly).

jobs:
  build:
    name: build-electron-from-react-web
# env:
# VERSION: 1.0.1
# update versions below
runs-on: ${{ matrix.os }}
strategy:
  matrix:
    os: [ubuntu-la…

View full answer

weide-zhou · 2020-03-26T06:55:27Z

weide-zhou
Mar 26, 2020

Hi @mandolyte ,

Thank you for being here!

‘Workflow&Job level env’ and matrix doesn’t accept variables, hence you can set the artifacts/asset name in step level.

2. The version string comes its package.json. And I want to run the workflow when I push the tag for v1.0.1.

>> You can get the tag version from ‘${GITHUB_REF##*v}’, and compare the value in ‘package.json’, use if expression to execute the next steps accordingly.

In total, i assume your script can be changed as below(I removed macos part you can add accordingly).

jobs:
  build:
    name: build-electron-from-react-web
# env:
# VERSION: 1.0.1
# update versions below
runs-on: ${{ matrix.os }}
strategy:
  matrix:
    os: [ubuntu-latest, windows-latest]

include:
- os: ubuntu-latest
artifact_name: book-package-app_1.0.1_amd64.deb
asset_name: book-package-app_1.0.1_amd64.deb
- os: windows-latest
artifact_name: "book-package-app Setup 1.0.1.exe"
asset_name: "book-package-app Setup 1.0.1.exe"
steps:
  - name: checkout
    uses: actions/checkout@v2
  - name: set tag version #If needed, here you can can compare the value form package.json with ${GITHUB_REF##*v}.
    shell: bash
    run: |
      echo "::set-env name=version::${GITHUB_REF##*v}"

  - name: set artifact&amp;asset name for ubuntu
    if: runner.os=='linux'
    run: |
      echo "::set-env name=artifactname::book-package-app_${version}_amd64.deb"
      echo "::set-env name=assetname::book-package-app_${version}_amd64.deb"
  - name: set artifact&amp;asset name for windows
    shell: bash
    if: runner.os=='windows'
    run: |
      echo "::set-env name=artifactname::book-package-app Setup ${version}.exe"
      echo "::set-env name=assetname::book-package-app Setup ${version}.exe"
  - name: Upload Release Assets
    uses: svenstaro/upload-release-action@v1-release
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    with:
      repo_token: ${{ secrets.GITHUB_TOKEN }}
      file: "./electron/dist/${{ env.artifactname }}"
      asset_name: ${{ env.assetname }}
      tag: ${{ github.ref }}
      overwrite: true

Hope it helps!

0 replies

mandolyte · 2020-03-26T15:29:47Z

mandolyte
Mar 26, 2020
Author

@weide-zhou

I think I spoke too soon. Looks like env vars are not allowed where I need them. Hope you have another idea!

0 replies

weide-zhou · 2020-03-27T01:52:46Z

weide-zhou
Mar 27, 2020

Hi @mandolyte ,

Thanks for your reply! The env value to get in action ‘with’ should use the format : ${{ env.artifactname }}

I have changed in my first post, thanks.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Community

Electron-Builder installers for multi platforms #25177

{{title}}

Replies: 3 comments

{{title}}

include:

- os: ubuntu-latest

artifact_name: book-package-app_1.0.1_amd64.deb

asset_name: book-package-app_1.0.1_amd64.deb

- os: windows-latest

artifact_name: "book-package-app Setup 1.0.1.exe"

asset_name: "book-package-app Setup 1.0.1.exe"

{{title}}

{{title}}

Select a reply

GitHub Community

Electron-Builder installers for multi platforms #25177

mandolyte Mar 25, 2020

Replies: 3 comments

weide-zhou Mar 26, 2020

include:

- os: ubuntu-latest

artifact_name: book-package-app_1.0.1_amd64.deb

asset_name: book-package-app_1.0.1_amd64.deb

- os: windows-latest

artifact_name: "book-package-app Setup 1.0.1.exe"

asset_name: "book-package-app Setup 1.0.1.exe"

mandolyte Mar 26, 2020 Author

weide-zhou Mar 27, 2020

mandolyte
Mar 25, 2020

weide-zhou
Mar 26, 2020

mandolyte
Mar 26, 2020
Author

weide-zhou
Mar 27, 2020