Ah, okay. So if I just leave it as-is and they fix the issue it won’t be a problem?

Yeah, if you don’t mind extra notifications. I’m not touching mine waiting for a fix - beauty of betas :]

I can confirm that this works for me now:

if: github.event.pull_request.draft == false

Thanks for pointing it out!

Because of this, I have found a better way for myself.

on:
  pull_request:
    types: [review_requested, ready_for_review]

See
https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-event-pull_request
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#onevent_nametypes

@julioromano
Could you provide your configuration? Because, it should work. We use it in our configuration and it is working very well.

@viktorianer 

name: My CI
on:

push:

branches: [master]

tags:

- '*'

pull_request:

types: [review_requested, ready_for_review]

jobs:

build:

runs-on: ubuntu-latest

steps:

# omitted

@julioromano
Thank you.

But I do not see my suggested solution in your configuration 🙄.

Sorry brainfart :slight_smile: I edited it.

I pasted wrong code while trying other solutions.

@julioromano I think it is not working because you have these two lines here, which is not what I suggested. 

@julioromano wrote:

@viktorianer 

 

name: My CI

on:
push:
branches: [master]
…

---

You should remove them. 

It should look like this:

name: reviewdog
on:
  pull_request:
    types: [review_requested, ready_for_review]
jobs:
  ...:

I tested it, still not very practical : it would run action once after undrafting or review request, but not for further pushes on the PR (e.g. when the reviewer asked changes and the developer pushes them).

When your actions are running tests or lint… it’s not ideal.

Just invite the reviewer again (small refresh button next to the name). It is not really good, but works. Unlike other things.

It seems to me that you should just use both:

on:  
  pull_request:
    types: [opened, synchronize, reopened, ready_for_review]
jobs:
  JOB:
    if: github.event.pull_request.draft == false

So it won’t run while draft, but it does run when undrafting and for future updates.

@natario1’s solution works very well! Thanks!

I have one issue though: When I press “Ready for review”, it takes a couple of seconds for the new run to trigger. During that time the check is marked as passed. It’s enough time to easily merge the pull request. This makes it possible to accidentally bypass the branch protection rule that the check must pass before merging. 😱

on:  
  pull_request:
    types: [opened, synchronize, reopened, ready_for_review]
jobs:
  JOB:
    if: github.event.pull_request.draft == false

This would be a simpler solution

on:  
  pull_request:
jobs:

JOB:

if: github.event.pull_request.draft == false

@chenrui333 nope, your simpler version won’t work, see the official notes:

Note: By default, a workflow only runs when a pull_request 's activity type is opened , synchronize , or reopened . To trigger workflows for more activity types, use the types keyword.

Events that trigger workflows - GitHub Docs

//docs.github.com/en/actions/reference/events-that-trigger-workflows

You can add an additional job that fails if pull request is a draft to prevent the bypass problem:

Example:

  fail_if_pull_request_is_draft:
    if: github.event.pull_request.draft == true
    runs-on: ubuntu-18.04
    steps:
    - name: Fails in order to indicate that pull request needs to be marked as ready to review and unit tests workflow needs to pass.
      run: exit 1