I’m not colour blind, and I found the red-on-black/green-on-black hard to distinguish on a diff. +1 for a lighter dark mode.
more contrast in the PRs.
maybe lighter green and red colours?
Thanks for sharing this feedback @YazanAlhalabi! We’ve been hearing quite a bit feedback about contrast in our Diffs view and have already started working on a new iteration of the design to hopefully help with this issue.
Thats great to hear! Cannot wait🔥
+1 from my side as well. Not colorblind, and struggling with the PR diffs
Here’s an interesting blog post on the dark dark mode subject. I think it’s worth a read and an acting upon:
For what it’s worth, my personal dark theme of choice in my text editor uses yellow and purple instead of red and green and while it takes some getting used to the meanings of each colour, it does work very well against a dark background chromatically speaking.
I am not colorblind, but also find it difficult to differentiate current red/green highlighting in diff in dark mode. Would be nice to make them less subtle.
For reference: this is how SourceTree implements it - much more convenient:
I switched back to light mode but I really want to use dark mode when this changed is rolled out
How can I know when it’s released ?
Thanks for the efforts!
First of all, I’ve been waiting for the dark mode for ages on the web. This is so cool
It is a bit hard to find what code is added and what code is removed while reviewing changes in a PR. It would be great if you choose better colors or highlight the deleted/added code in a different way so people can easily find out what’s added/removed.
Thanks for sharing the feedback @yashwanthbabu! We’ve gotten quite a bit of community feedback on the legibility of the diff views and are currently exploring alternative designs. I’m going to merge this topic with the other to keep them all in one place.
I gave dark mode a spin, and generally really like it. However, I found that the suggested change feature in PRs is very difficult to read. It may be because I’m colour blind, I’m not sure, but it’s difficult to work with.
I have a screenshot of light mode, but I can’t post two embeds, so you’ll just have to take a look at the dark mode issue:
There’s just not enough distinction between the two blocks. It’s not super clear in the light mode, but it’s better than with the banded lines.
I wanted to give feedback on exactly the same thing
I go everywhere for dark mode, and was super excited for GH dark mode, but I changed back to light mode because the diff color is hard to identify
Thanks @Antnee & @ThreePalmTrees for sharing the feedback last month! We’ve received quite a bit of feedback on the Diff views from our community and have already started exploring alternative designs that have improved legibility. I’m going to merge with a similar topic to keep all related feedback in one place
Hi @pquinn262 - we now have early mockups ready for our new Deuteranomaly red/green colorblind theme and would love to chat with you in the next week or so to get your thoughts and feedback! If you’re still interested, here is a Calendly link that you can use to select a time that works best for you.
Hi everyone! Thanks for the continued feedback.
We’ve recently been updating colors across all of our themes in order to help improve contrast. These updates will ship to all users within the next week, but can currently be tested by opting in to the dark high contrast theme in Feature Preview (located in your upper right profile drop down). You do not have to change your theme settings in order to test the updated color variables. We would love to hear your feedback on whether or not you believe this improves the contrast of red/green diff colors!
Hey @gaknoll! Thanks for helping improve the visibility for all us colorblinders!
I enabled the high contrast mode and it’s still a bit hard for me to see between added and removed. The problem is made a little worse if Mac’s Night Shift is enabled and maxed on
Note, this is a screenshot of screenshots because of the error: “Sorry, new users can only put one embedded media item in a post.”