Skip to content

CODEOWNER Required Reviews #22522

Nov 15, 2017 · 19 comments · 1 reply
Discussion options

You must be logged in to vote

It’s hard to say why you’re experiencing this behavior without some more information. Is the repository in question public? Can you share a link to a specific PR that is behaving in a way that you believe is not expected?

Assuming that the repository in question is private, I can guess at one reason why more than one reviewer might be required. Let’s say you have a CODEOWNERS like the following:

* @foo @bar @baz

In this case, any PR would require one (and only one) of those three people to approve it before it could be merged. But let’s say you have a more complex CODEOWNERS file:

*.js @foo @bar
docs/ @baz

And you submit a PR that includes both a JavaScript change as well as a change to…

Replies: 19 comments 1 reply

Comment options

You must be logged in to vote
0 replies
Answer selected
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
1 reply
@tleerai
Comment options

Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet