I’ve got a repository with 3 total collaborators, and the master/dev branches are set up to be:
- require PR reviews
- require review from Code Owners
Now, as I understood things, my open PR towards the dev branch should request a review from all Code Owners, but a single approved review should be enough to review.
My PR automatically requested review from the other two collaborators, since both are Code Owners. So far, so good. One of them requested changes, which we discussed, made, and then approved. So the current status of his review is “approved”–yet this is not enough to merge the PR?
The status box says
Code owner review required
Waiting on code owner review from xxxxxxxxxxxx.
Required statuses must pass before mergingAll required status checks on this pull request must run successfully to enable automatic merging.
There are no status checks enabled (beyond required reviews), and I have at least one approved review, so I fail to see why the merge button didn’t turn that shiny Green (I have full privilege on the repo, so presumably I can merge when the review is approved).
Is there any way to make sure at least one approved review is enough to merge the PR, or is this one of those “since it’s your PR you can’t merge it” things?