-
To make it more consistent with command palettes in other websites/applications, maybe you should consider changing the key bind to ⌘+⇧+P? This is the same as Visual Studio Code and numerous other IDEs and text editors. |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments
-
Yes, please don’t hijack my browser’s shortcut to focus the search bar! |
Beta Was this translation helpful? Give feedback.
-
If they would just allow the key binding to be customized, then people could do what they want. I also prefer the idea of Command + Shift + P, to be consistent with all the editors that use this convention.
The new command palette action at GitHub.com is fantastic. Is it possible to allow the user to make a custom keybinding to it? Most editors use Command + Shift + P to launch the command palette. |
Beta Was this translation helpful? Give feedback.
-
The entire world uses Cmd/Ctrl-Shift-P, please don’t reinvent this! |
Beta Was this translation helpful? Give feedback.
-
GH is exploring key remappings so these shortcuts can be fully customized in the future.
(edited original comment to be more accurate) Thanks @josephtlyons, @dorner & @thatgeoguy for the feedback! We actually originally used command+p for our internal staff ship but couldn’t get around bugs with it inconsistently pulling up the print dialog. Therefore we chose to go with command+k (and Windows/Linux equivalents) with the command+option+k alternate. I’ve shared this with our team to discuss a workaround. For now if it’s breaking your browser experience you are able to turn off the f… |
Beta Was this translation helpful? Give feedback.
-
As @inkblotty reposted, we did in fact start with command+p and command+shift+p but were unable to consistently override the browser print dialog (which was quite frustrating). We have gotten a lot of feedback on this already and will be discussing as a team how we could improve this experience and/or give users more control / customization. In the meantime, if overriding the browser search bar command is too frustrating, you can disable the command palette via Feature Preview in your profile dropdown while we work on a solution for you. |
Beta Was this translation helpful? Give feedback.
-
Here’s a userland workaround: This userscript remaps Cmd+Shift+P to Cmd+K. Works on Mac only. Maybe someone can create a version of this that also works on Windows/Linux.
|
Beta Was this translation helpful? Give feedback.
-
Hi everyone! We just shipped a new feature that allows you to customize the keyboard shortcuts used to open the command palette. You can now customize the keyboard shortcuts for opening the command palette in search and command modes in the Accessibility section of your user settings. |
Beta Was this translation helpful? Give feedback.
-
Ctrl+Shift+P is Private Browsing in Firefox. Don't hijack this. |
Beta Was this translation helpful? Give feedback.
As @inkblotty reposted, we did in fact start with command+p and command+shift+p but were unable to consistently override the browser print dialog (which was quite frustrating). We have gotten a lot of feedback on this already and will be discussing as a team how we could improve this experience and/or give users more control / customization.
In the meantime, if overriding the browser search bar command is too frustrating, you can disable the command palette via Feature Preview in your profile dropdown while we work on a solution for you.