Bug: Clicking on PR commit links causes 404

We have started seeing bizarre behavior in PRs, for example in the following PR, clicking on any of the commit links leads to a 404. https://github.com/SerenityOS/serenity/pull/10098

9 Likes

Same here, on all repositiories and in browser incognito mode.

As an alternative way to view commits, you can go to the commit tab: eg. https://github.com/SerenityOS/serenity/pull/10098/commits

Clicking on a commit there give you the expected commit, and not a 404.

1 Like

The issue seems to be that links on the “Conversation” tab direct to the fork repository instead of directing to the upstream repository.

For instance, on https://github.com/SerenityOS/serenity/pull/10098, links point to:

https://github.com/linusg/serenity/pull/10098/commits/<SHA1>

instead of:

https://github.com/SerenityOS/serenity/pull/10098/commits/<SHA1>

The links on the “Commits” tab are directing to the right repository.

I guess someone at GitHub made a change, but only checked for PRs within the same repository, and didn’t test PRs between repositories.

So any reply from Github on this issue?, its bin a week already
Well, that was fast, issue seems resolved on my end. Thank you!

1 Like

Thank you for accepting here to me

Amazing information… THank you so much