GitHub Community
Badge is always showing "failing" #25846
-
|
Hi there. For some reason I can’t figure out, the badge for my workflow is always showing “failing” even through the worflow is not failing. Here is the badge: https://github.com/badsyntax/richard-willis-vscode-extension-pack/workflows/Node%20CI/badge.svg Here is the workflow: https://github.com/badsyntax/richard-willis-vscode-extension-pack/actions?workflow=Node+CI It seems like the badge should be showing the success state. I really can’t figure out why it’s not. Anyone got any pointers? Thanks in advance. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments
-
|
Hi @badsyntax, I looked into it quickly and don’t see anything wrong with your badge URL. Filed an issue internally to have someone take a look into it. Thanks for the detailed report! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @badsyntax , we’ve made a change to allow filtering by event types and defaulted that filter to the As a quick workaround you could specify the
but I can see how the current behavior is confusing, and we’ll take a look to change the default behavior. Thanks, Chris |
Beta Was this translation helpful? Give feedback.
-
|
We’ve deployed a change to not default to the Thanks, Chris |
Beta Was this translation helpful? Give feedback.
-
|
Awesome thank you! :slight_smile: |
Beta Was this translation helpful? Give feedback.
We’ve deployed a change to not default to the
pushevent, the badge you posted should now work as expected.Thanks,
Chris